Classify polygon rings to distinguish inner polygon rings and multipolygons #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the reason to keep it non-semver-major now that we have earcut in master + VT2? We could merge #33 instead and then eliminate duplicated |
jfirebaugh
force-pushed
the
backward-compatible-classify-rings
branch
from
2545ae5 to
c16b5c0
Compare
|
@jfirebaugh yeah, sounds good. |
Per chat confirmed this is not longer an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a non-semver-major reimplementation of #33 that applies ring classification only in
toGeoJSON. The structure of the return value ofloadGeometry()is unchanged.This is needed for mapbox/mapbox-gl-js#2586.
However, I can't get a GeoJSON Polygon with inner ring to round trip through a mapnik created vector tile. As the failing test here shows, it comes out with ring order indicating a multipolygon. cc @flippmoke @springmeyer @mourner.